Fix crash when double clicking and dragging an item on small window sizes - #10134
Merged
Merged
Conversation
LocalIdentity
approved these changes
Aug 6, 2026
LocalIdentity
changed the title
LocalIdentity
merged commit Aug 6, 2026
ffbb8b1
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10129
Description of the problem being solved:
This fixes the possibility of a crash with a nil check on the method that is used for (I think) getting the drag text. But this also fixes the stuck drag issue by disallowing it on double click. With double clicks it was possible to start an invalid drag if the second click was outside the item. This happened when the window scrolls a lot to the right, or just naturally if you have low fps (debugger)
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: